contrib/k8s.io/client-go: inject the traceID as kube auditID #351
Conversation
JulienBalestra
force-pushed
the
JulienBalestra/kube-audit
branch
from
06636c6
to
2e4b22e
Compare
| } | ||
| kubeAuditID := strconv.FormatUint(traceID, 10) | ||
| req.Header.Set("Audit-Id", kubeAuditID) | ||
| span.SetTag("kubernetes.auditID", kubeAuditID) |
There was a problem hiding this comment.
I think kubernetes.audit_id would be more standard to APM (and the actual header itself). Would this change be troublesome for you?
There was a problem hiding this comment.
Not at all 👍
| })) | ||
| } | ||
|
|
||
| func requestToResource(method, path string) string { | ||
| func RequestToResource(method, path string) string { |
There was a problem hiding this comment.
Why was this made public API? If there's a good reason it's fine, but then let's clearly document it.
There was a problem hiding this comment.
I would like to use this part of the code to generate traces from the apiserver side while parsing the Kubernetes audit logs.
It avoids me to repeat this function and keep a coherence there.
The goal of this is to set a distributed trace.
Does it make sense ?
I'll document this properly.
There was a problem hiding this comment.
Sure. Let's keep it then. Was just making sure this was intentional.
| })) | ||
| } | ||
|
|
||
| func requestToResource(method, path string) string { | ||
| func RequestToResource(method, path string) string { |
There was a problem hiding this comment.
Sure. Let's keep it then. Was just making sure this was intentional.
Co-Authored-By: JulienBalestra <julien.balestra@gmail.com>
Co-Authored-By: JulienBalestra <julien.balestra@gmail.com>
JulienBalestra
force-pushed
the
JulienBalestra/kube-audit
branch
from
1f0ddbe
to
3271bf4
Compare
gbbr
changed the title
| traceID := span.Context().TraceID() | ||
| if traceID == 0 { | ||
| // tracer is not running | ||
| return |
There was a problem hiding this comment.
What's wrong with the alignment here?
There was a problem hiding this comment.
I accepted the github suggestion 😆 going to fix it in the old way
There was a problem hiding this comment.
Ok then I'll take the fall for that 😅
Signed-off-by: JulienBalestra <julien.balestra@datadoghq.com>
JulienBalestra
force-pushed
the
JulienBalestra/kube-audit
branch
from
8951903
to
4a9ba3a
Compare
|
Will include this in 1.5.0 next week. |
This allows to provide the Kubernetes Audit-ID to the kube-apiserver see.
With this change, we could then use datadog distributing tracing capabilities (audit logs) in the apiserver side.