use a seeded/thread-safe random number generator for span ids #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we get the right error messages when the assertion fails.
|
Fixes #46. |
ufoot
reviewed
Apr 10, 2017
| @@ -52,6 +55,12 @@ func NewTracer() *Tracer { | |||
|
|
|||
| // NewTracerTransport create a new Tracer with the given transport. | |||
| func NewTracerTransport(transport Transport) *Tracer { | |||
| randSource, err := newRandSource() | |||
| if err != nil { | |||
| panic(fmt.Sprintf("cannot create random source: %v", err)) | |||
There was a problem hiding this comment.
I'm a little worried with panicking here, if, for some reason, creating the rand source we should probably log it, make it blatant there's a problem, and make all tracing no-op so that no span/trace are sent, making it clear something is going wrong. If we do panic here for real, we might stop user code and create an outage on our behalf. Generally speaking, panicking on totally unexpected thing is OK, but here we're hooking ourselves on existing code, trying to be as furtive as possible.
| @@ -60,7 +60,7 @@ func TestTracesAgentIntegration(t *testing.T) { | |||
| for _, tc := range testCases { | |||
| transport := newHTTPTransport(defaultHostname, defaultPort) | |||
| response, err := transport.SendTraces(tc.payload) | |||
| assert.Nil(err) | |||
| assert.NoError(err) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.