reuse connections: always close the response.Body #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commented on seeing errors with lost traces[1] After digging deeper is the my hypothesis was that 1. `lost traces` errors are caused due new connections being established which may sometimes exceed 1s(configured) timeout 2. connections aren't being reused because `response.Body` doesn't get always closed 3. every new connection may potentially result in `lost traces` errors since it may exceed the 1s timeout I've patched the transport locally and seeing exactly what expected: - no more repeated lost traces: because connections are mostly reused - but occasional lost trace(on startup) likely because of 3. since 1s timeout is still too short for new connection - [1] DataDog#181 (comment)
|
Looks like it won't work… closing… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented on seeing errors with lost traces[1]
Problem
After digging deeper into [1] my hypothesis is
lost traceserrors are caused due new connections being established which may sometimes exceed 1s(configured) timeoutresponse.Bodydoesn't get always closedlost traceserrors since it may exceed the 1s timeoutObservations
I've patched the transport locally and confirming my expectations:
References