contrib/net/http: cause the default config to set the analytics rate in spanOpts #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in spanOpts WrapHandler fails to set the EventSampleRate tag as ServeMux.ServeHTTP does. Rather than relying on ServeMux.ServeHTTP and WrapHandler to individually set the tag, we will have the defaults function set the tag in the config if the global analytics rate is not NaN.
gbbr
reviewed
Jan 10, 2020
|
Fixed the tests, added testing for regression that I have confirmed fails without this patch. |
gbbr
reviewed
Jan 13, 2020
gbbr
reviewed
Jan 13, 2020
contrib/net/http/http_test.go
Outdated
| assert.Len(t, spans, 1) | ||
| s := spans[0] | ||
| assert.Equal(t, rate, s.Tag(ext.EventSampleRate)) | ||
| asserts := []func(t *testing.T, mt mocktracer.Tracer, rate interface{}, opts ...Option){ |
There was a problem hiding this comment.
Would a map with a string key help be more descriptive?
contrib/net/http/http_test.go
Outdated
| t.Run("defaults", func(t *testing.T) { | ||
| mt := mocktracer.Start() | ||
| defer mt.Stop() | ||
| for assert := range asserts { |
There was a problem hiding this comment.
I think we are overusing and shadowing this name “assert”. It’s a test, maybe “test” is better? You could use the suggested map’s key string as the name
There was a problem hiding this comment.
You're right. There are too many things called "assert." I think a map with a string name is better.
|
The tests are failing due to a grpc library issue. I'll leave this here for now and address that issue in a separate PR. |
|
The issue was fixed upstream. See: #566 |
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
…in spanOpts (DataDog#564) WrapHandler fails to set the EventSampleRate tag as ServeMux.ServeHTTP does. Rather than relying on ServeMux.ServeHTTP and WrapHandler to individually set the tag, we will have the defaults function set the tag in the config if the global analytics rate is not NaN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WrapHandler fails to set the EventSampleRate tag as ServeMux.ServeHTTP does.
Rather than relying on ServeMux.ServeHTTP and WrapHandler to individually set
the tag, we will have the defaults function set the tag in the config if the global analytics
rate is not NaN.