Raphael/gocql #73
Merged
Raphael/gocql #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talwai
reviewed
Jun 12, 2017
tracer/contrib/gocql/gocqltrace.go
Outdated
|
|
||
| // TraceQuery wraps a gocql.Query into a TracedQuery | ||
| func TraceQuery(service string, tracer *tracer.Tracer, q *gocql.Query) *TracedQuery { | ||
| string_query := strings.SplitN(q.String(), "\"", 3)[1] |
talwai
reviewed
Jun 12, 2017
| service string | ||
| keyspace string | ||
| paginated string | ||
| consistancy string |
talwai
reviewed
Jun 12, 2017
tracer/contrib/gocql/gocqltrace.go
Outdated
|
|
||
| // TraceQuery wraps a gocql.Query into a TracedQuery | ||
| func TraceQuery(service string, tracer *tracer.Tracer, q *gocql.Query) *TracedQuery { | ||
| string_query := strings.SplitN(q.String(), "\"", 3)[1] |
There was a problem hiding this comment.
what is this split doing exactly? seems very opaque. Can you add a test describing the behavior?
There was a problem hiding this comment.
q.String() returns for a query: (exemple) [query statement="SELECT * from trace.person" values=[] consistency=QUORUM]
So in between the two first " there's the query
There was a problem hiding this comment.
This doesn't work - I'm getting "Non-parsable SQL query" - add a test
talwai
reviewed
Jun 12, 2017
tracer/contrib/gocql/gocqltrace.go
Outdated
| // TraceQuery wraps a gocql.Query into a TracedQuery | ||
| func TraceQuery(service string, tracer *tracer.Tracer, q *gocql.Query) *TracedQuery { | ||
| string_query := strings.SplitN(q.String(), "\"", 3)[1] | ||
| q.NoSkipMetadata() |
There was a problem hiding this comment.
what does NoSkipMetadata do?
|
We've been using this version prod for a couple of days now. Looking fine. |
ufoot
added a commit
that referenced
this pull request
Jun 19, 2017
This contains two PRs: - #73 branch raphael/gocql (Cassandra support) - #78 branch christian/flushchannel (fix partial traces bug) Those 2 branches had conflicts, and the commit 6952e85 fixes the interactions between them. Additionnally, it has been running for 3 complete days on our prod env, so considered stable enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gocql query wrapper
Implementation:
Data we get 100% time:
query, errors, row count, pagestateData we only get when the query returns columns:
keyspaceData we will get once this is merged gocql/gocql#918 :
host, port, clustername