Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/jinzhu/gorm: Add err check #806

Merged
merged 6 commits into from
Jan 11, 2021
Merged

contrib/jinzhu/gorm: Add err check #806

merged 6 commits into from
Jan 11, 2021

Conversation

moonsub-kim
Copy link
Contributor

An implementation of #805

@knusbaum knusbaum added this to the 1.29.0 milestone Jan 7, 2021
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Please upmerge to the latest v1 to get the CI to pass.

contrib/jinzhu/gorm/option.go Outdated Show resolved Hide resolved
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@knusbaum knusbaum merged commit a5f08bc into DataDog:v1 Jan 11, 2021
dianashevchenko pushed a commit that referenced this pull request Feb 8, 2021
This commit adds the WithErrorCheck option, which allows users to specify a
function that will determine whether a given gorm error should be marked as
an error in the span.
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants