Add pid to root spans #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ufoot
approved these changes
Jul 5, 2017
tracer/ext/system.go
Outdated
|
|
||
| // Standard error message metadata fields. | ||
| const ( | ||
| Pid = "system.pid" |
There was a problem hiding this comment.
I suspect a good Go linter would require a comment here.
| span.Finish() | ||
| span.SetMeta("finished.test", "true") | ||
| assert.Equal(len(span.Meta), 1) | ||
| assert.Equal(len(span.Meta), nMeta) |
There was a problem hiding this comment.
Always feeling sad when I see this, I think testify expects the "expected value" to be on the left side (first arg) and the actual value on the right side. But then, the rest of this file (and of the project) has been done the wrong way. I'm mixed. But feel free to rewrite them the other way, it's just a nitpick anyway, makes error messages clearer.
There was a problem hiding this comment.
Mea culpa, I had noticed but I was lazy ;) It's fixed now.
For the record :%s/(assert[^(])((.), (.*))/\1(\3, \2)/gc in vim does the work pretty well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automatically adds the process id of the current process as a metadata when creating a new root span.