Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/globalsign/mgo: check for error after dialing to avoid panic #937

Merged
merged 3 commits into from
Jul 22, 2021
Merged

contrib/globalsign/mgo: check for error after dialing to avoid panic #937

merged 3 commits into from
Jul 22, 2021

Conversation

knusbaum
Copy link
Contributor

Fixes #870

@knusbaum knusbaum added bug unintended behavior that has to be fixed apm:ecosystem contrib/* related feature requests or bugs labels May 26, 2021
@knusbaum knusbaum added this to the 1.32.0 milestone May 26, 2021
@knusbaum knusbaum requested a review from gbbr May 26, 2021 20:35
@knusbaum
Copy link
Contributor Author

@gbbr @felixge could you take a look?

@knusbaum knusbaum requested a review from felixge June 30, 2021 14:40
felixge
felixge approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knusbaum knusbaum modified the milestones: 1.32.0, 1.33.0 Jul 22, 2021
@knusbaum knusbaum merged commit 63dea35 into v1 Jul 22, 2021
@knusbaum knusbaum deleted the knusbaum/fix-mgo branch July 22, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixge felixge felixge approved these changes

@gbbr gbbr Awaiting requested review from gbbr

Assignees
No one assigned
Labels
apm:ecosystem contrib/* related feature requests or bugs bug unintended behavior that has to be fixed
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.

globalsign/mgo: panic
2 participants
@knusbaum @felixge