contrib/confluentinc/confluent-kafka-go/kafka: Use kafka headers as c… #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexa00
force-pushed
the
fix-kafka-context-passing
branch
from
742c291
to
2085592
Compare
knusbaum
requested changes
Jun 29, 2021
There was a problem hiding this comment.
Hi, @hexa00
We should include clear examples of how to use this, as well as tests for the behavior.
We also need to maintain the existing behavior for anyone using the WithContext option. IMO, we should mark WithContext deprecated.
|
@knusbaum thank you, a few questions:
|
|
Sorry, I should have been clearer. :)
Thanks. |
|
@knusbaum great thanks for the info, I'll work on that today |
hexa00
force-pushed
the
fix-kafka-context-passing
branch
2 times, most recently
from
2316c21
to
80bbf8d
Compare
|
@knusbaum this PR is ready for a second look: Changes:
Let me know what you think, thanks! :) |
knusbaum
requested changes
Jul 8, 2021
| @@ -0,0 +1,80 @@ | |||
| package kafka_test | |||
There was a problem hiding this comment.
Please add the license header to this file.
…ontext when producing Before this patch when producing a message, the general producer context was used when producing messages. This made it impossible to attach a parent span to a produced message. With this patch messages headers are checked when producing messages for a span context and the span is created as a child if a parent span is present. This patch deprecates the WithContext() option for consumer and producers. Fixed DataDog#941
hexa00
force-pushed
the
fix-kafka-context-passing
branch
from
a6fd2a1
to
de6aa0a
Compare
|
@knusbaum indeed , fixed and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ontext when producing
Before this patch when producing a message, the general producer context was
used when producing messages.
This made it impossible to attach a parent span to a produced message.
With this patch messages headers are checked when producing messages for a span
context and the span is created as a child if a parent span is present.
Also StartSpanFromContext is changed to just StarSpan since using the global
consumer/producer context has no use.
Fixed #941