contrib/go-pg/pg.v10 add options, ServiceName #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knusbaum
requested changes
Jun 22, 2021
There was a problem hiding this comment.
Hi, @pzvalenta. Thanks for the PR.
It looks mostly good, but I have some style change requests for you.
Also, we should probably add tests for the analytics options. They should be easy to copy from other contrib packages.
|
Thanks for your review. Added TestAnalyticsRate test inspired by gorm tests and TestServiceName inspired gintracing tests. Both tests are based on the original TestSelect in this package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds options
Implements #951