Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.circleci: pin github.com/hashicorp/consul/api to v1.8.1 #956

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

knusbaum
Copy link
Contributor

@knusbaum knusbaum commented Jun 23, 2021

github.com/hashicorp/consul/api@v1.9.0 has broken compatibility with
versions of go less than 1.16. For now, we are pinning this to the previous
release, v1.8.1, until the issue is resolved.

See: hashicorp/consul#10470

github.com/hashicorp/consul/api@v1.9.0 has broken compatibility with
versions of go less than 1.16. For now, we are pinning this to the previous
release, v1.8.1, until the issue is resolved.
@knusbaum knusbaum added this to the 1.32.0 milestone Jun 23, 2021
@knusbaum knusbaum requested review from gbbr and felixge June 23, 2021 21:02
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will fix CI, but customers will still have to do this pinning on their end as well if they want to use our wrapper, right? (That's okay with me, just making sure I understand)

@felixge
Copy link
Member

felixge commented Jun 28, 2021

Can we merge this? It's currently holding up my #942 PR.

@gbbr gbbr merged commit 1abcab6 into v1 Jun 28, 2021
@gbbr gbbr deleted the knusbaum/consul_version branch June 28, 2021 11:51
@felixge
Copy link
Member

felixge commented Jun 28, 2021

Thanks @gbbr 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants