Fix resource leak in RequestImplementationClassLoaderMatcher

DataDog · Jun 4, 2024 · 22eb622 · 22eb622
1 parent 3ef9225
commit 22eb622
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/....3/src/main/java/datadog/trace/instrumentation/jetty8/RequestGetPartsInstrumentation.java b/....3/src/main/java/datadog/trace/instrumentation/jetty8/RequestGetPartsInstrumentation.java
@@ -86,17 +86,15 @@ public static class RequestImplementationClassLoaderMatcher
 
     @Override
     protected boolean doMatch(ClassLoader cl) {
-      InputStream is = cl.getResourceAsStream("org/eclipse/jetty/server/Request.class");
-      if (is == null) {
-        return false;
-      }
-      try {
+      try (InputStream is = cl.getResourceAsStream("org/eclipse/jetty/server/Request.class")) {
+        if (is == null) {
+          return false;
+        }
         ClassReader classReader = new ClassReader(is);
         final boolean[] foundField = new boolean[1];
         final boolean[] foundGetParameters = new boolean[1];
         classReader.accept(new ClassLoaderMatcherClassVisitor(foundField, foundGetParameters), 0);
         return !foundField[0] && foundGetParameters[0];
-
       } catch (IOException e) {
         return false;
       }