tracing libraries must configure the tracer sampling mechanism so tha…

…t, by default, 1 trace per minute gets sent.
DataDog · May 21, 2024 · 4de6ebc · 4de6ebc
1 parent 6804c8c
commit 4de6ebc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/dd-trace-core/src/main/java/datadog/trace/common/sampling/Sampler.java b/dd-trace-core/src/main/java/datadog/trace/common/sampling/Sampler.java
@@ -34,7 +34,7 @@ final class Builder {
     public static Sampler forConfig(final Config config, final TraceConfig traceConfig) {
       Sampler sampler;
       if (config != null) {
-        if(!config.isTraceEnabled() && config.areTracingDependantProductsEnabled()){
+        if (!config.isTraceEnabled() && config.areTracingDependantProductsEnabled()) {
           log.debug("APM is disabled. Only 1 trace per minute will be sent.");
           return new ServiceAsmTimeTraceSampler();
         }

diff --git a/dd-trace-core/src/main/java/datadog/trace/common/sampling/ServiceAsmTimeTraceSampler.java b/dd-trace-core/src/main/java/datadog/trace/common/sampling/ServiceAsmTimeTraceSampler.java
@@ -6,16 +6,14 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-
-
 public class ServiceAsmTimeTraceSampler implements Sampler, PrioritySampler {
 
   private static final Logger log = LoggerFactory.getLogger(ServiceAsmTimeTraceSampler.class);
 
   private final SimpleRateLimiter rateLimiter;
 
   public ServiceAsmTimeTraceSampler() {
-    this.rateLimiter = new SimpleRateLimiter(60); //one per minute
+    this.rateLimiter = new SimpleRateLimiter(60); // one per minute
   }
 
   @Override
@@ -28,18 +26,12 @@ public <T extends CoreSpan<T>> boolean sample(final T span) {
   @Override
   public <T extends CoreSpan<T>> void setSamplingPriority(final T span) {
 
-    //TODO check how to short circuit this for ASM
+    // TODO check how to short circuit this for ASM
 
     if (rateLimiter.tryAcquire()) {
-      span.setSamplingPriority(
-          PrioritySampling.SAMPLER_KEEP,
-          SamplingMechanism.DEFAULT);
+      span.setSamplingPriority(PrioritySampling.SAMPLER_KEEP, SamplingMechanism.DEFAULT);
     } else {
-      span.setSamplingPriority(
-          PrioritySampling.SAMPLER_DROP,
-          SamplingMechanism.DEFAULT);
+      span.setSamplingPriority(PrioritySampling.SAMPLER_DROP, SamplingMechanism.DEFAULT);
     }
-
   }
-
 }