Skip to content

Commit

Permalink
Restructure hibernate integration
Browse files Browse the repository at this point in the history
  • Loading branch information
willgittoes-dd committed Mar 20, 2019
1 parent 4825a11 commit 8c5158f
Show file tree
Hide file tree
Showing 35 changed files with 94 additions and 92 deletions.
Expand Up @@ -34,7 +34,7 @@ dependencies {
compileOnly group: 'org.hibernate', name: 'hibernate-core', version: '3.5.0-Final'

compile project(':dd-java-agent:agent-tooling')
compile project(':dd-java-agent:instrumentation:hibernate-common')
compile project(':dd-java-agent:instrumentation:hibernate')

compile deps.bytebuddy
compile deps.opentracing
Expand Down
@@ -1,4 +1,4 @@
package datadog.trace.instrumentation.hibernate.v3_5;
package datadog.trace.instrumentation.hibernate.core.v3_5;

import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static java.util.Collections.singletonMap;
Expand All @@ -11,8 +11,8 @@
import datadog.trace.agent.tooling.Instrumenter;
import datadog.trace.bootstrap.ContextStore;
import datadog.trace.bootstrap.InstrumentationContext;
import datadog.trace.instrumentation.hibernate.common.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.common.SessionState;
import datadog.trace.instrumentation.hibernate.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.SessionState;
import java.util.Map;
import net.bytebuddy.asm.Advice;
import net.bytebuddy.description.method.MethodDescription;
Expand All @@ -36,13 +36,13 @@ public Map<String, String> contextStore() {
@Override
public String[] helperClassNames() {
return new String[] {
"datadog.trace.instrumentation.hibernate.common.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.common.SessionState",
"datadog.trace.instrumentation.hibernate.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.SessionState",
"datadog.trace.agent.decorator.BaseDecorator",
"datadog.trace.agent.decorator.ClientDecorator",
"datadog.trace.agent.decorator.DatabaseClientDecorator",
"datadog.trace.agent.decorator.OrmClientDecorator",
"datadog.trace.instrumentation.hibernate.common.HibernateDecorator",
"datadog.trace.instrumentation.hibernate.HibernateDecorator",
};
}

Expand Down
@@ -1,7 +1,7 @@
package datadog.trace.instrumentation.hibernate.v4_0;
package datadog.trace.instrumentation.hibernate.core.v3_5;

import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.common.HibernateDecorator.DECORATOR;
import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR;
import static java.util.Collections.singletonMap;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
Expand All @@ -12,8 +12,8 @@
import datadog.trace.agent.tooling.Instrumenter;
import datadog.trace.bootstrap.ContextStore;
import datadog.trace.bootstrap.InstrumentationContext;
import datadog.trace.instrumentation.hibernate.common.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.common.SessionState;
import datadog.trace.instrumentation.hibernate.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.SessionState;
import java.util.Map;
import net.bytebuddy.asm.Advice;
import net.bytebuddy.description.method.MethodDescription;
Expand All @@ -38,13 +38,13 @@ public Map<String, String> contextStore() {
@Override
public String[] helperClassNames() {
return new String[] {
"datadog.trace.instrumentation.hibernate.common.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.common.SessionState",
"datadog.trace.instrumentation.hibernate.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.SessionState",
"datadog.trace.agent.decorator.BaseDecorator",
"datadog.trace.agent.decorator.ClientDecorator",
"datadog.trace.agent.decorator.DatabaseClientDecorator",
"datadog.trace.agent.decorator.OrmClientDecorator",
"datadog.trace.instrumentation.hibernate.common.HibernateDecorator",
"datadog.trace.instrumentation.hibernate.HibernateDecorator",
};
}

Expand Down
@@ -1,7 +1,7 @@
package datadog.trace.instrumentation.hibernate.v3_5;
package datadog.trace.instrumentation.hibernate.core.v3_5;

import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.common.HibernateDecorator.DECORATOR;
import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR;
import static java.util.Collections.singletonMap;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
Expand All @@ -14,7 +14,7 @@
import datadog.trace.agent.tooling.Instrumenter;
import datadog.trace.bootstrap.ContextStore;
import datadog.trace.bootstrap.InstrumentationContext;
import datadog.trace.instrumentation.hibernate.common.SessionState;
import datadog.trace.instrumentation.hibernate.SessionState;
import io.opentracing.Span;
import io.opentracing.util.GlobalTracer;
import java.util.HashMap;
Expand Down Expand Up @@ -45,12 +45,12 @@ public Map<String, String> contextStore() {
@Override
public String[] helperClassNames() {
return new String[] {
"datadog.trace.instrumentation.hibernate.common.SessionState",
"datadog.trace.instrumentation.hibernate.SessionState",
"datadog.trace.agent.decorator.BaseDecorator",
"datadog.trace.agent.decorator.ClientDecorator",
"datadog.trace.agent.decorator.DatabaseClientDecorator",
"datadog.trace.agent.decorator.OrmClientDecorator",
"datadog.trace.instrumentation.hibernate.common.HibernateDecorator",
"datadog.trace.instrumentation.hibernate.HibernateDecorator",
};
}

Expand Down
@@ -1,8 +1,8 @@
package datadog.trace.instrumentation.hibernate.v3_5;
package datadog.trace.instrumentation.hibernate.core.v3_5;

import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.common.HibernateDecorator.DECORATOR;
import static datadog.trace.instrumentation.hibernate.common.SessionMethodUtils.SCOPE_ONLY_METHODS;
import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR;
import static datadog.trace.instrumentation.hibernate.SessionMethodUtils.SCOPE_ONLY_METHODS;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
import static net.bytebuddy.matcher.ElementMatchers.named;
Expand All @@ -15,8 +15,8 @@
import datadog.trace.agent.tooling.Instrumenter;
import datadog.trace.bootstrap.ContextStore;
import datadog.trace.bootstrap.InstrumentationContext;
import datadog.trace.instrumentation.hibernate.common.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.common.SessionState;
import datadog.trace.instrumentation.hibernate.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.SessionState;
import io.opentracing.Span;
import java.util.Collections;
import java.util.HashMap;
Expand Down Expand Up @@ -53,13 +53,13 @@ public Map<String, String> contextStore() {
@Override
public String[] helperClassNames() {
return new String[] {
"datadog.trace.instrumentation.hibernate.common.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.common.SessionState",
"datadog.trace.instrumentation.hibernate.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.SessionState",
"datadog.trace.agent.decorator.BaseDecorator",
"datadog.trace.agent.decorator.ClientDecorator",
"datadog.trace.agent.decorator.DatabaseClientDecorator",
"datadog.trace.agent.decorator.OrmClientDecorator",
"datadog.trace.instrumentation.hibernate.common.HibernateDecorator",
"datadog.trace.instrumentation.hibernate.HibernateDecorator",
};
}

Expand Down
@@ -1,4 +1,4 @@
package datadog.trace.instrumentation.hibernate.v3_5;
package datadog.trace.instrumentation.hibernate.core.v3_5;

import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static java.util.Collections.singletonMap;
Expand All @@ -12,8 +12,8 @@
import datadog.trace.agent.tooling.Instrumenter;
import datadog.trace.bootstrap.ContextStore;
import datadog.trace.bootstrap.InstrumentationContext;
import datadog.trace.instrumentation.hibernate.common.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.common.SessionState;
import datadog.trace.instrumentation.hibernate.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.SessionState;
import java.util.Map;
import net.bytebuddy.asm.Advice;
import net.bytebuddy.description.method.MethodDescription;
Expand All @@ -36,13 +36,13 @@ public Map<String, String> contextStore() {
@Override
public String[] helperClassNames() {
return new String[] {
"datadog.trace.instrumentation.hibernate.common.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.common.SessionState",
"datadog.trace.instrumentation.hibernate.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.SessionState",
"datadog.trace.agent.decorator.BaseDecorator",
"datadog.trace.agent.decorator.ClientDecorator",
"datadog.trace.agent.decorator.DatabaseClientDecorator",
"datadog.trace.agent.decorator.OrmClientDecorator",
"datadog.trace.instrumentation.hibernate.common.HibernateDecorator",
"datadog.trace.instrumentation.hibernate.HibernateDecorator",
};
}

Expand Down
Expand Up @@ -27,7 +27,7 @@ dependencies {
compileOnly group: 'org.hibernate', name: 'hibernate-core', version: '4.0.0.Final'

compile project(':dd-java-agent:agent-tooling')
compile project(':dd-java-agent:instrumentation:hibernate-common')
compile project(':dd-java-agent:instrumentation:hibernate')

compile deps.bytebuddy
compile deps.opentracing
Expand All @@ -48,5 +48,5 @@ dependencies {
latestDepTestCompile group: 'org.hibernate', name: 'hibernate-core', version: '+'
latestDepTestCompile group: 'com.h2database', name: 'h2', version: '1.4.197'
// Test that the incremental instrumentation for hibernate 4.3 doesn't cause issues.
latestDepTestCompile project(':dd-java-agent:instrumentation:hibernate-4.3')
latestDepTestCompile project(':dd-java-agent:instrumentation:hibernate:core-4.3')
}
@@ -1,4 +1,4 @@
package datadog.trace.instrumentation.hibernate.v4_0;
package datadog.trace.instrumentation.hibernate.core.v4_0;

import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static java.util.Collections.singletonMap;
Expand All @@ -11,8 +11,8 @@
import datadog.trace.agent.tooling.Instrumenter;
import datadog.trace.bootstrap.ContextStore;
import datadog.trace.bootstrap.InstrumentationContext;
import datadog.trace.instrumentation.hibernate.common.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.common.SessionState;
import datadog.trace.instrumentation.hibernate.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.SessionState;
import java.util.Map;
import net.bytebuddy.asm.Advice;
import net.bytebuddy.description.method.MethodDescription;
Expand All @@ -36,13 +36,13 @@ public Map<String, String> contextStore() {
@Override
public String[] helperClassNames() {
return new String[] {
"datadog.trace.instrumentation.hibernate.common.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.common.SessionState",
"datadog.trace.instrumentation.hibernate.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.SessionState",
"datadog.trace.agent.decorator.BaseDecorator",
"datadog.trace.agent.decorator.ClientDecorator",
"datadog.trace.agent.decorator.DatabaseClientDecorator",
"datadog.trace.agent.decorator.OrmClientDecorator",
"datadog.trace.instrumentation.hibernate.common.HibernateDecorator",
"datadog.trace.instrumentation.hibernate.HibernateDecorator",
};
}

Expand Down
@@ -1,7 +1,7 @@
package datadog.trace.instrumentation.hibernate.v3_5;
package datadog.trace.instrumentation.hibernate.core.v4_0;

import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.common.HibernateDecorator.DECORATOR;
import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR;
import static java.util.Collections.singletonMap;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
Expand All @@ -12,8 +12,8 @@
import datadog.trace.agent.tooling.Instrumenter;
import datadog.trace.bootstrap.ContextStore;
import datadog.trace.bootstrap.InstrumentationContext;
import datadog.trace.instrumentation.hibernate.common.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.common.SessionState;
import datadog.trace.instrumentation.hibernate.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.SessionState;
import java.util.Map;
import net.bytebuddy.asm.Advice;
import net.bytebuddy.description.method.MethodDescription;
Expand All @@ -38,13 +38,13 @@ public Map<String, String> contextStore() {
@Override
public String[] helperClassNames() {
return new String[] {
"datadog.trace.instrumentation.hibernate.common.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.common.SessionState",
"datadog.trace.instrumentation.hibernate.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.SessionState",
"datadog.trace.agent.decorator.BaseDecorator",
"datadog.trace.agent.decorator.ClientDecorator",
"datadog.trace.agent.decorator.DatabaseClientDecorator",
"datadog.trace.agent.decorator.OrmClientDecorator",
"datadog.trace.instrumentation.hibernate.common.HibernateDecorator",
"datadog.trace.instrumentation.hibernate.HibernateDecorator",
};
}

Expand Down
@@ -1,7 +1,7 @@
package datadog.trace.instrumentation.hibernate.v4_0;
package datadog.trace.instrumentation.hibernate.core.v4_0;

import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.common.HibernateDecorator.DECORATOR;
import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR;
import static java.util.Collections.singletonMap;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
Expand All @@ -14,7 +14,7 @@
import datadog.trace.agent.tooling.Instrumenter;
import datadog.trace.bootstrap.ContextStore;
import datadog.trace.bootstrap.InstrumentationContext;
import datadog.trace.instrumentation.hibernate.common.SessionState;
import datadog.trace.instrumentation.hibernate.SessionState;
import io.opentracing.Span;
import io.opentracing.util.GlobalTracer;
import java.util.Map;
Expand All @@ -39,12 +39,12 @@ public Map<String, String> contextStore() {
@Override
public String[] helperClassNames() {
return new String[] {
"datadog.trace.instrumentation.hibernate.common.SessionState",
"datadog.trace.instrumentation.hibernate.SessionState",
"datadog.trace.agent.decorator.BaseDecorator",
"datadog.trace.agent.decorator.ClientDecorator",
"datadog.trace.agent.decorator.DatabaseClientDecorator",
"datadog.trace.agent.decorator.OrmClientDecorator",
"datadog.trace.instrumentation.hibernate.common.HibernateDecorator",
"datadog.trace.instrumentation.hibernate.HibernateDecorator",
};
}

Expand Down
@@ -1,8 +1,8 @@
package datadog.trace.instrumentation.hibernate.v4_0;
package datadog.trace.instrumentation.hibernate.core.v4_0;

import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.instrumentation.hibernate.common.HibernateDecorator.DECORATOR;
import static datadog.trace.instrumentation.hibernate.common.SessionMethodUtils.SCOPE_ONLY_METHODS;
import static datadog.trace.instrumentation.hibernate.HibernateDecorator.DECORATOR;
import static datadog.trace.instrumentation.hibernate.SessionMethodUtils.SCOPE_ONLY_METHODS;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
import static net.bytebuddy.matcher.ElementMatchers.named;
Expand All @@ -15,8 +15,8 @@
import datadog.trace.agent.tooling.Instrumenter;
import datadog.trace.bootstrap.ContextStore;
import datadog.trace.bootstrap.InstrumentationContext;
import datadog.trace.instrumentation.hibernate.common.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.common.SessionState;
import datadog.trace.instrumentation.hibernate.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.SessionState;
import io.opentracing.Span;
import java.util.Collections;
import java.util.HashMap;
Expand Down Expand Up @@ -51,13 +51,13 @@ public Map<String, String> contextStore() {
@Override
public String[] helperClassNames() {
return new String[] {
"datadog.trace.instrumentation.hibernate.common.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.common.SessionState",
"datadog.trace.instrumentation.hibernate.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.SessionState",
"datadog.trace.agent.decorator.BaseDecorator",
"datadog.trace.agent.decorator.ClientDecorator",
"datadog.trace.agent.decorator.DatabaseClientDecorator",
"datadog.trace.agent.decorator.OrmClientDecorator",
"datadog.trace.instrumentation.hibernate.common.HibernateDecorator",
"datadog.trace.instrumentation.hibernate.HibernateDecorator",
};
}

Expand Down
@@ -1,4 +1,4 @@
package datadog.trace.instrumentation.hibernate.v4_0;
package datadog.trace.instrumentation.hibernate.core.v4_0;

import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static java.util.Collections.singletonMap;
Expand All @@ -12,8 +12,8 @@
import datadog.trace.agent.tooling.Instrumenter;
import datadog.trace.bootstrap.ContextStore;
import datadog.trace.bootstrap.InstrumentationContext;
import datadog.trace.instrumentation.hibernate.common.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.common.SessionState;
import datadog.trace.instrumentation.hibernate.SessionMethodUtils;
import datadog.trace.instrumentation.hibernate.SessionState;
import java.util.Map;
import net.bytebuddy.asm.Advice;
import net.bytebuddy.description.method.MethodDescription;
Expand All @@ -36,13 +36,13 @@ public Map<String, String> contextStore() {
@Override
public String[] helperClassNames() {
return new String[] {
"datadog.trace.instrumentation.hibernate.common.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.common.SessionState",
"datadog.trace.instrumentation.hibernate.SessionMethodUtils",
"datadog.trace.instrumentation.hibernate.SessionState",
"datadog.trace.agent.decorator.BaseDecorator",
"datadog.trace.agent.decorator.ClientDecorator",
"datadog.trace.agent.decorator.DatabaseClientDecorator",
"datadog.trace.agent.decorator.OrmClientDecorator",
"datadog.trace.instrumentation.hibernate.common.HibernateDecorator",
"datadog.trace.instrumentation.hibernate.HibernateDecorator",
};
}

Expand Down
Expand Up @@ -27,7 +27,7 @@ dependencies {
compileOnly group: 'org.hibernate', name: 'hibernate-core', version: '4.3.0.Final'

compile project(':dd-java-agent:agent-tooling')
compile project(':dd-java-agent:instrumentation:hibernate-4.0')
compile project(':dd-java-agent:instrumentation:hibernate:core-4.0')

compile deps.bytebuddy
compile deps.opentracing
Expand Down

0 comments on commit 8c5158f

Please sign in to comment.