Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jax RS Tracing broken #424

Closed
chouze opened this issue Aug 2, 2018 · 9 comments
Closed

Jax RS Tracing broken #424

chouze opened this issue Aug 2, 2018 · 9 comments
Labels
tag: needs investigation Issues needing investigations type: bug

Comments

@chouze
Copy link
Member

chouze commented Aug 2, 2018

We upgraded our java agent to version 0.12.0 and noticed that we no longer received any traces for servlet.request in the Datadog APM dashboard. To the best of our knowledge we still received all the traces for all other types. We reverted back down to 0.11.0 and started receiving the servlet.request traces again. We are running jetty version 9.3.6.v20151106 and jersey version 2.22.1.

@tylerbenson
Copy link
Contributor

Thanks for the report. Would it be possible to open a support ticket so you can provide some logs and such?

@tylerbenson tylerbenson added type: bug tag: needs investigation Issues needing investigations labels Aug 3, 2018
@chouze
Copy link
Member Author

chouze commented Aug 3, 2018

Opened ticket #160129 for this issue.

@tylerbenson
Copy link
Contributor

@chouze We are waiting for a response on that ticket. Providing logs, specifically the jvm startup logs with -Ddatadog.slf4j.simpleLogger.defaultLogLevel=debug enabled would be especially helpful.

Thanks!

@chouze
Copy link
Member Author

chouze commented Aug 13, 2018

Hello, sorry for the delay, I've sent in a few minutes of logs.

@tylerbenson
Copy link
Contributor

@chouze We've made a fair bit of changes since 0.12.0. I was wondering if you'd be willing to try again. I don't have any particular reason to think we've fixed it, but I also don't know what is causing it, so I'm kinda hoping it's been unintentionally resolved. This is the particular log line that is problematic:

[main] DEBUG datadog.trace.agent.tooling.AgentInstaller$LoggingListener - Failed to handle javax.servlet.http.HttpServlet for transformation on classloader sun.misc.Launcher$AppClassLoader@18b4aac2: Cannot resolve type description for javax.servlet.ServletRequest

Thanks!

@chouze
Copy link
Member Author

chouze commented Sep 17, 2018

Hi @tylerbenson, I just tried with 0.15.0~71059eac It seems to be having the same issue as 0.12.0

@tylerbenson
Copy link
Contributor

@choze, darn. I was hopeful. Is it possible for you to provide a small sample app that reproduces the problem?

Can you tell me more about your application environment? Using Spring Boot, OSGi, or some other non-standard classloading setup?

@ghost
Copy link

ghost commented Feb 27, 2019

from my experience, servlet.request is reported for spring boot services, but jersey services use a different format which is based on the class name and method name of the API endpoint. Perhaps that is the point of confusion?

@randomanderson
Copy link
Contributor

Closing as abandoned.

We've made significant improvements to the tracer in the past year (and specifically Jax-rs more recently)

Please open a new issue if the problem persists with a newer version of the tracer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: needs investigation Issues needing investigations type: bug
Projects
None yet
Development

No branches or pull requests

3 participants