Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new configuation key for setting debug log level #1033

Merged
merged 4 commits into from
Oct 10, 2019

Conversation

cecile75
Copy link
Collaborator

@cecile75 cecile75 commented Oct 8, 2019

Priority: datadog.slf4j.simpleLogger.defaultLogLevel > dd.trace.debug > DD_TRACE_DEBUG
Tests written in LogLevelTest.groovy

@cecile75 cecile75 requested a review from a team as a code owner October 8, 2019 13:46
@dougqh
Copy link
Contributor

dougqh commented Oct 8, 2019

If we can do so easily, I think it would be good to add some tests.

Copy link
Contributor

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks reasonable to me.

@tylerbenson
Copy link
Contributor

@cecile75 to test, you will probably want to do something similar to CustomLogManagerTest... at this level, we can't unit test, so you'll need to run the full agent. Perhaps the best way to validate correctness is to check if the debug system property gets set.

@cecile75 cecile75 force-pushed the cecile/loglevelconfiguration branch from 41bb839 to a08253d Compare October 9, 2019 16:04
@cecile75 cecile75 merged commit 2ebbab2 into master Oct 10, 2019
@cecile75 cecile75 deleted the cecile/loglevelconfiguration branch October 10, 2019 10:29
@tylerbenson tylerbenson added this to the 0.34.0 milestone Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants