Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease cache size and make soft values #1039

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Decrease cache size and make soft values #1039

merged 1 commit into from
Oct 11, 2019

Conversation

tylerbenson
Copy link
Contributor

Attempt to reduce memory overhead requirements. Based on feedback, it seems 10k was overly agressive. In memory constrained environments, use soft values to ensure the cache isn’t pushing usage over the limit.

@tylerbenson
Decrease cache size and make soft values
4679b07 
Attempt to reduce memory overhead requirements.  Based on feedback, it seems 10k was overly agressive.  In memory constrained environments, use soft values to ensure the cache isn’t pushing usage over the limit.
@tylerbenson tylerbenson requested a review from a team as a code owner October 10, 2019 16:21
@dougqh dougqh assigned dougqh and unassigned dougqh Oct 11, 2019
@dougqh dougqh requested review from dougqh and removed request for dougqh October 11, 2019 08:35
dougqh
dougqh approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@dougqh dougqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think reducing the cache size & switching to SoftReferences are our best short term options.
If problems persist, we can come back & take a deeper look.

@tylerbenson tylerbenson merged commit 9ee74fb into master Oct 11, 2019
@tylerbenson tylerbenson deleted the tyler/cache-size branch October 11, 2019 08:51
@tylerbenson tylerbenson added this to the 0.34.0 milestone Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougqh dougqh dougqh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.34.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tylerbenson @dougqh