Add support for jedis 3.0+ #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2019 15:09
devinsba
commented
Dec 5, 2019
| isMethod() | ||
| .and(isPublic()) | ||
| .and(named("sendCommand")) | ||
| .and(takesArgument(1, named("redis.clients.jedis.commands.ProtocolCommand"))), |
There was a problem hiding this comment.
This is a copy of the 1.4 instrumentation except that the method argument was changed to an interface that Protocol.Command implements
Comment on lines
+10
to
+11
| private static final String SERVICE_NAME = "redis"; | ||
| private static final String COMPONENT_NAME = SERVICE_NAME + "-command"; |
There was a problem hiding this comment.
I moved these from the other class because they weren't used there but could be used here
|
Failing tests were: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1114