Disable decorators via config #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinsba
approved these changes
Dec 19, 2019
tylerbenson
reviewed
Dec 19, 2019
| @@ -596,6 +596,10 @@ public boolean isJmxFetchIntegrationEnabled( | |||
| return jmxFetchIntegrationEnabled(integrationNames, defaultEnabled); | |||
| } | |||
|
|
|||
| public boolean isDecoratorEnabled(final String name) { | |||
| return getBooleanSettingFromEnvironment("trace." + name.toLowerCase() + ".enabled", true); | |||
There was a problem hiding this comment.
@andrewsouthard1 any objections to this config setting?
dougqh
reviewed
Dec 23, 2019
| new Status5XXDecorator(), | ||
| new URLAsResourceName())) { | ||
|
|
||
| if (Config.get().isDecoratorEnabled(decorator.getClass().getSimpleName())) { |
There was a problem hiding this comment.
I realize I'm a bit late, but none-the-less...
I think it is better to have a separate name other than the class name for any configuration setting.
Fortunately, It won't be hard for us to make that change in the future.
|
FYI, system properties are case sensitive, so the property needs to be set as lowercase. I'll update the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to disable individual decorators with config.
ex:
-Ddd.trace.status404decorator.enabled=falseNote: system properties are case sensitive, and we do a
toLowerCase, so the system property should also be all lowercase.Closes #1143