Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use streams directly in DatadogClassLoader #1179

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Use streams directly in DatadogClassLoader #1179

merged 1 commit into from
Jan 16, 2020

Conversation

randomanderson
Copy link
Contributor

Before:

JarInputStream -> ByteArrayOutputStream -> byte[] (stored) -> ByteArrayInputStream

Now:

JarInputStream

The internal steps were vestigial from when the full bytes of every class was cached at startup. This change shaves 6MB in old gen memory usage.

@randomanderson randomanderson requested a review from a team as a code owner January 15, 2020 21:43
@randomanderson randomanderson added the tag: performance Performance related changes label Jan 15, 2020
@randomanderson randomanderson merged commit 64ed09d into master Jan 16, 2020
@randomanderson randomanderson deleted the landerson/internal-jar-memory branch January 16, 2020 15:51
@devinsba devinsba added this to the 0.42.0 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinsba devinsba devinsba approved these changes

@tylerbenson tylerbenson tylerbenson approved these changes

Assignees
No one assigned
Labels
tag: performance Performance related changes
Projects
None yet
Milestone
0.42.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@randomanderson @devinsba @tylerbenson