Fix potential StackOverFlowError on regexp #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
reviewed
Jan 29, 2020
|
|
||
| private final Map<String, Set<String>> classMethodsToTrace; | ||
|
|
||
| private boolean validateConfigString(String configString) { | ||
| for (String clazz : configString.split(";")) { | ||
| if (!clazz.trim().matches(CONFIG_FORMAT)) { |
There was a problem hiding this comment.
I don't think clazz is the right variable name for this. Maybe segment instead?
tylerbenson
reviewed
Jan 29, 2020
| import datadog.trace.agent.test.utils.ConfigUtils | ||
| import datadog.trace.instrumentation.trace_annotation.TraceConfigInstrumentation | ||
|
|
||
| class TraceConfigInstrumentationTest extends AgentTestRunner { |
There was a problem hiding this comment.
I see you had a test but removed it? Any reason in particular?
There was a problem hiding this comment.
I wrote it to try to reproduce the StackOverflowError but realized it won't be so easy as stack size and memory for it will vary depending on JVM and environment. I had also overlooked the existing tests, there was an overlap and not much extra value so I decided to remove.
tylerbenson
approved these changes
Jan 29, 2020
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1191