Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set dispatcher span on request instead of clear #1196

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Set dispatcher span on request instead of clear #1196

merged 1 commit into from
Jan 31, 2020

Conversation

tylerbenson
Copy link
Contributor

Clearing the span caused traces to be broken up and reported independently when calling forward/include.

#1195

@tylerbenson
Set dispatcher span on request instead of clear
daae198 
Clearing the span caused traces to be broken up and reported independently when calling forward/include.
@tylerbenson tylerbenson added this to the 0.42.0 milestone Jan 31, 2020
@tylerbenson tylerbenson requested a review from a team as a code owner January 31, 2020 02:57
randomanderson
randomanderson approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@randomanderson randomanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@devinsba devinsba merged commit 8484763 into master Jan 31, 2020
@devinsba devinsba deleted the tyler/fix-span-attribute branch January 31, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinsba devinsba devinsba approved these changes

@randomanderson randomanderson randomanderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.42.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tylerbenson @devinsba @randomanderson