Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More general class loading instrumentation #1218

Merged

Conversation

trask
Copy link
Contributor

@trask trask commented Feb 13, 2020

Nice to be able to contribute something back! From open-telemetry/opentelemetry-java-instrumentation#152

@trask trask requested a review from a team as a code owner February 13, 2020 04:34
@trask
Copy link
Contributor Author

trask commented Feb 13, 2020

eeek! that's what i get for turning off test_ibm8 on opentelemetry-auto-instr-java to save $$

Copy link
Contributor

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the jmxfetch submodule get updated?

@trask trask force-pushed the more-general-class-loading-instrumentation branch from a481f23 to 94dd781 Compare February 13, 2020 19:32
@trask
Copy link
Contributor Author

trask commented Feb 13, 2020

@tylerbenson Oops! That was unintentional, fixed now.

@tylerbenson
Copy link
Contributor

Thanks for sharing it back!

@daparthi001
Copy link

@trask

when i am trying to get the dd-agent dd-java-agent-0.44.0.jar i am getting below error.

dd.trace 2020-03-02 16:21:33:778 +0000] [paxweb-config-1-thread-1] DEBUG datadog.trace.agent.tooling.AgentInstaller$TransformLoggingListener - Transformed org.eclipse.jetty.util.thread.QueuedThreadPool$2 -- org.ops4j.pax.web.pax-web-jetty-bundle [313]
Mar 02, 2020 4:21:33 PM org.ops4j.pax.web.service.internal.Activator updateController
SEVERE: Unable to start pax web server: datadog/trace/bootstrap/FieldBackedContextStoreAppliedMarker
java.lang.NoClassDefFoundError: datadog/trace/bootstrap/FieldBackedContextStoreAppliedMarker
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
at org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.defineClass(BundleWiringImpl.java:2410)
at org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.findClass(BundleWiringImpl.java:2194)
at org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1607)
at org.apache.felix.framework.BundleWiringImpl.access$200(BundleWiringImpl.java:80)
at org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:2053)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at org.eclipse.jetty.util.thread.QueuedThreadPool.(QueuedThreadPool.java:659)
at org.eclipse.jetty.util.thread.QueuedThreadPool.(QueuedThreadPool.java:99)
at org.eclipse.jetty.util.thread.QueuedThreadPool.(QueuedThreadPool.java:94)
at org.eclipse.jetty.util.thread.QueuedThreadPool.(QueuedThreadPool.java:89)
at org.eclipse.jetty.util.thread.QueuedThreadPool.(QueuedThreadPool.java:84)
at org.eclipse.jetty.util.thread.QueuedThreadPool.(QueuedThreadPool.java:79)
at org.eclipse.jetty.util.thread.QueuedThreadPool.(QueuedThreadPool.java:74)
at org.ops4j.pax.web.service.jetty.internal.JettyFactoryImpl.createServer(JettyFactoryImpl.java:88)
at org.ops4j.pax.web.service.jetty.internal.ServerControllerImpl$Stopped.start(ServerControllerImpl.java:448)
at org.ops4j.pax.web.service.jetty.internal.ServerControllerImpl.start(ServerControllerImpl.java:82)
at org.ops4j.pax.web.service.jetty.internal.ServerControllerFactoryImpl$1.start(ServerControllerFactoryImpl.java:164)
at org.ops4j.pax.web.service.jetty.internal.ServerControllerImpl$Unconfigured.configure(ServerControllerImpl.java:795)
at org.ops4j.pax.web.service.jetty.internal.ServerControllerImpl.configure(ServerControllerImpl.java:98)
at org.ops4j.pax.web.service.internal.Activator.updateController(Activator.java:418)
at org.ops4j.pax.web.service.internal.Activator.lambda$scheduleUpdateFactory$1(Activator.java:344)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ClassNotFoundException: datadog.trace.bootstrap.FieldBackedContextStoreAppliedMarker not found by org.ops4j.pax.web.pax-web-jetty-bundle [313]
at org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1639)
at org.apache.felix.framework.BundleWiringImpl.access$200(BundleWiringImpl.java:80)
at org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:2053)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 28 more

Mar 02, 2020 4:21:37 PM com.sun.jmx.interceptor.DefaultMBeanServerInterceptor getAttribute
FINER: Attribute = Usage, ObjectName = java.lang:type=MemoryPool,name=PS Old Gen

@trask
Copy link
Contributor Author

trask commented Mar 2, 2020

Hi @daparthi001, yeah 🙁, see fix in #1275

@daparthi001
Copy link

@trask Is this integrated in new build of java-agent ?When we will have new release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants