Create AgentBuilder with logging listeners only if in debug mode #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
suggested changes
Feb 19, 2020
dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/AgentInstaller.java
Show resolved
Hide resolved
heathkd
force-pushed
the
heather.dsouza/disable_log_listeners
branch
from
aa546a4
to
1be2f23
Compare
devinsba
suggested changes
Feb 20, 2020
dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/AgentInstaller.java
Show resolved
Hide resolved
devinsba
approved these changes
Feb 20, 2020
heathkd
force-pushed
the
heather.dsouza/disable_log_listeners
branch
from
1be2f23
to
b7b46ca
Compare
tylerbenson
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test the effectiveness of this change, a sample spring app was run multiple times with tracer 0.43.0 and 0.44.0 (the tracer with these changes) on non-debug mode. The average start-up time is shown below:
0.43.0 -> 12.996 s
0.44.0 -> 12.196 s
Not adding the listener on non-debug mode shaves a bit of time off start-up.