Remove costly matchers from ignore list #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing these matchers caused the time spent matching ignores to go from greater than 1 second to less than 100 ms.
tylerbenson
force-pushed
the
tyler/optimize-ignores
branch
from
8494f78
to
6e4b553
Compare
mar-kolya
reviewed
Feb 20, 2020
| // Unlikely to ever need to instrument an annotation: | ||
| .or(ElementMatchers.<TypeDescription>isAnnotation()) | ||
| // Unlikely to ever need to instrument an enum: | ||
| .or(ElementMatchers.<TypeDescription>isEnum()) |
There was a problem hiding this comment.
It is really-really surprising that these are slow - by the looks is it they should just be doing an & on two ints.
There was a problem hiding this comment.
Yes, it is a bit counter intuitive, but I think understand why.
My suspicion is that name checks don't actually require materializing the TypeDescription from the underlying class file, since the name is known ahead of time.
On the other hand, the enum & annotation flag are only present in the class file, so ByteBuddy probably has to load the class file to do the check.
If the TypeDescription were already loaded then I have no doubt that isEnum & isAnnotation would be cheaper than the name check.
dougqh
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing these matchers caused the time spent matching ignores in my sample app to go from greater than 1 second to less than 100 ms.