Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single ignores matcher #1245

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Single ignores matcher #1245

merged 3 commits into from
Feb 21, 2020

Conversation

mar-kolya
Copy link
Contributor

This doesn't seem to provide immediate perf impact, but this should simplify matcher optimization later.

@mar-kolya mar-kolya requested a review from a team as a code owner February 21, 2020 16:56
@mar-kolya mar-kolya force-pushed the mar-kolya/single-ignores-matcher branch from 3b4f932 to 27842d8 Compare February 21, 2020 16:56
devinsba
devinsba approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@devinsba devinsba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, I imagine this results in less allocations which can't hurt

@mar-kolya mar-kolya merged commit 1f8acaf into master Feb 21, 2020
@mar-kolya mar-kolya deleted the mar-kolya/single-ignores-matcher branch February 21, 2020 17:42
@randomanderson randomanderson added this to the 0.44.0 milestone Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinsba devinsba devinsba approved these changes

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.44.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mar-kolya @devinsba @randomanderson