Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ByteBuddy raw setting at startup #1247

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Set ByteBuddy raw setting at startup #1247

merged 1 commit into from
Feb 22, 2020

Conversation

tylerbenson
Copy link
Contributor

This reduces the complexity of TypeDefinitions.

Benchmark                                                             Mode  Cnt   Score   Error  Units
ClassRetransformingBenchmark.WithAgent.testTracedRetransform          avgt       22.450          ms/op
ClassRetransformingBenchmark.WithAgent.testUntracedRetransform        avgt        6.842          ms/op
ClassRetransformingBenchmark.WithAgentMaster.testTracedRetransform    avgt       23.188          ms/op
ClassRetransformingBenchmark.WithAgentMaster.testUntracedRetransform  avgt        7.009          ms/op

It also improved startup time by about 1 sec.

This reduces the complexity of TypeDefinitions.
```
Benchmark                                                             Mode  Cnt   Score   Error  Units
ClassRetransformingBenchmark.WithAgent.testTracedRetransform          avgt       22.450          ms/op
ClassRetransformingBenchmark.WithAgent.testUntracedRetransform        avgt        6.842          ms/op
ClassRetransformingBenchmark.WithAgentMaster.testTracedRetransform    avgt       23.188          ms/op
ClassRetransformingBenchmark.WithAgentMaster.testUntracedRetransform  avgt        7.009          ms/op
```
It also improved startup time by about 1 sec.
@tylerbenson tylerbenson requested a review from a team as a code owner February 21, 2020 18:36
@tylerbenson tylerbenson added the tag: performance Performance related changes label Feb 21, 2020
@tylerbenson tylerbenson changed the title Set ByteBuddy raw setting at startup Merge pull request #1247 from DataDog/tyler/bb-raw Feb 22, 2020
@tylerbenson tylerbenson merged commit b27b30d into master Feb 22, 2020
@tylerbenson tylerbenson deleted the tyler/bb-raw branch February 22, 2020 00:30
@tylerbenson tylerbenson changed the title Merge pull request #1247 from DataDog/tyler/bb-raw Set ByteBuddy raw setting at startup Feb 24, 2020
@randomanderson randomanderson added this to the 0.44.0 milestone Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: performance Performance related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants