Avoid calling superclass matcher where possible #1248
Conversation
| .and( | ||
| safeExtendsClass( | ||
| named("com.netflix.hystrix.HystrixCommand") | ||
| .or(named("com.netflix.hystrix.HystrixObservableCommand")))); |
There was a problem hiding this comment.
I think some of these are safe, but many aren't. For example, HystrixCommand is intended to be extended, so most usages of this won't match the package prefix. I'm guessing many of these others have a similar issue.
| @@ -31,7 +32,9 @@ | |||
|
|
|||
| @Override | |||
| public ElementMatcher<TypeDescription> typeMatcher() { | |||
| return not(isInterface()).and(safeHasInterface(named("org.hibernate.Criteria"))); | |||
| return nameStartsWith("org.hibernate.") | |||
There was a problem hiding this comment.
I don't think this one can be done. I've seen custom Criteria classes before
There was a problem hiding this comment.
reverged whole hibernate and a few others
mar-kolya
force-pushed
the
mar-kolya/reduce-superclass-matcher-exposure
branch
4 times, most recently
from
ef575a7
to
91a56b3
Compare
Saves about 100ms of startup time on test app
mar-kolya
force-pushed
the
mar-kolya/reduce-superclass-matcher-exposure
branch
from
91a56b3
to
b6d374e
Compare
|
The change seems like a nice improvement overall, but I'm wondering if we need to adjust our level of abstraction at some point -- not for this PR. Specifically, I'm wondering if we should have a method on the Instrumenter that describes whether to search just a subset of packages. I also think we could stand to create some helper methods for common idioms like... |
Saves about 300ms of startup time on test app