Make CommonTaskExecutor periodic tasks safe
#1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Verify that we can schedule task and catch exceptions. This should help to avoid additional exceptions on app crash during startup. * Avoid holding strong references from within executor to make sure that things can get GCed.
mar-kolya
force-pushed
the
mar-kolya/safe-periodic-tasks
branch
from
3d25596
to
1fb844a
Compare
tylerbenson
reviewed
Apr 13, 2020
utils/thread-utils/src/main/java/datadog/common/exec/CommonTaskExecutor.java
Outdated
Show resolved
Hide resolved
dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/Cleaner.java
Outdated
Show resolved
Hide resolved
| static final SpanCleanerTask INSTANCE = new SpanCleanerTask(); | ||
|
|
||
| @Override | ||
| public void run(final SpanCleaner target) { |
There was a problem hiding this comment.
Consider removing SpanCleaner and have this accept the list of pendingTraces instead. (Implement the run logic above directly.)
There was a problem hiding this comment.
if (cleaner != null) {
cleaner.close();
}
- this makes things somewhat more interesting since we cannot hold reference to pending traces inside the task.
Would it be ok if I add a fixme for now here - this seems less trivial change?
utils/thread-utils/src/main/java/datadog/common/exec/CommonTaskExecutor.java
Show resolved
Hide resolved
utils/thread-utils/src/main/java/datadog/common/exec/CommonTaskExecutor.java
Outdated
Show resolved
Hide resolved
utils/thread-utils/src/main/java/datadog/common/exec/CommonTaskExecutor.java
Outdated
Show resolved
Hide resolved
tylerbenson
reviewed
Apr 13, 2020
utils/thread-utils/src/main/java/datadog/common/exec/CommonTaskExecutor.java
Outdated
Show resolved
Hide resolved
Also move CleanerTest to PeriodicSchedulingTest
tylerbenson
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help to avoid additional exceptions on app crash during
startup.
that things can get GCed.