Cache byte[] for the last 64 tags #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
approved these changes
Jun 4, 2020
dougqh
reviewed
Jun 4, 2020
| @@ -107,7 +126,21 @@ private static void writeUTF8Tag(final String value, final MessagePacker destina | |||
| destination.packRawStringHeader(interned.length); | |||
| destination.addPayload(interned); | |||
| } else { | |||
| destination.packString(value); | |||
| byte[] bytes = null; | |||
There was a problem hiding this comment.
Oops, I see misunderstood. This is covering the value. Nice.
tylerbenson
reviewed
Jun 4, 2020
| // Something went wrong. We will write out the string the normal way. | ||
| } | ||
| } | ||
| if (bytes != null) { |
There was a problem hiding this comment.
When would this ever be null?
There was a problem hiding this comment.
If the string is "" or if the tagCache.get throws an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes roughly
30%of allbyte[]allocations and70%of allsun.nio.cs.UTF_8$Encoderallocations during apet-clinicrun.Not sure about the cache size.