Send data to trace agent when no API key is given #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-kolya
reviewed
Jun 4, 2020
...ofiling/profiling-uploader/src/main/java/com/datadog/profiling/uploader/ProfileUploader.java
Show resolved
Hide resolved
mar-kolya
reviewed
Jun 4, 2020
mar-kolya
reviewed
Jun 4, 2020
cimi
force-pushed
the
cimi/send-profiles-to-trace-agent
branch
4 times, most recently
from
5fd590b
to
54f4c15
Compare
mar-kolya
reviewed
Jun 10, 2020
...ofiling/profiling-uploader/src/main/java/com/datadog/profiling/uploader/ProfileUploader.java
Show resolved
Hide resolved
mar-kolya
reviewed
Jun 10, 2020
...profiling/profiling-uploader/src/main/java/com/datadog/profiling/uploader/ContainerInfo.java
Outdated
Show resolved
Hide resolved
mar-kolya
requested changes
Jun 10, 2020
cimi
force-pushed
the
cimi/send-profiles-to-trace-agent
branch
from
aaa8512
to
28a83c9
Compare
|
Sorry for the noise, I struggled to have this working end to end in my development environment and I wanted to test both changes (allow missing api key and add container id header). I've removed the container ID changes and will open another PR for that. @AlexJF helped me understand the agent setup in our devenv and we were able to see data coming through successfully for applications with no API key and with this property set: |
|
Related PR (container IDs): #1569 |
cimi
force-pushed
the
cimi/send-profiles-to-trace-agent
branch
from
28a83c9
to
1e88bb8
Compare
cimi
force-pushed
the
cimi/send-profiles-to-trace-agent
branch
from
1e88bb8
to
1253cce
Compare
mar-kolya
reviewed
Jun 10, 2020
AlexJF
approved these changes
Jun 11, 2020
dd-java-agent/agent-profiling/src/main/java/com/datadog/profiling/agent/ProfilingAgent.java
Outdated
Show resolved
Hide resolved
AlexJF
reviewed
Jun 11, 2020
...ofiling/profiling-uploader/src/main/java/com/datadog/profiling/uploader/ProfileUploader.java
Show resolved
Hide resolved
cimi
force-pushed
the
cimi/send-profiles-to-trace-agent
branch
from
1253cce
to
8c63d72
Compare
AlexJF
reviewed
Jun 11, 2020
...ofiling/profiling-uploader/src/main/java/com/datadog/profiling/uploader/ProfileUploader.java
Show resolved
Hide resolved
cimi
force-pushed
the
cimi/send-profiles-to-trace-agent
branch
from
edcf348
to
05d1d98
Compare
cimi
force-pushed
the
cimi/send-profiles-to-trace-agent
branch
from
05d1d98
to
35734f7
Compare
mar-kolya
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.