PROF-1622: Sample all exceptions #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegreystone
approved these changes
Jun 8, 2020
tylerbenson
approved these changes
Jun 8, 2020
| * don't instrument {@linkplain Error} class/subclasses since they are tracked by a native JFR event | ||
| * already. | ||
| */ | ||
| /** Provides instrumentation of {@linkplain Throwable} constructor. <br> */ | ||
| @AutoService(Instrumenter.class) | ||
| public final class ExceptionInstrumentation extends Instrumenter.Default { |
There was a problem hiding this comment.
The class name should be renamed to match.
There was a problem hiding this comment.
I will rename only the advice and instrumentation classes since they deal with the exact class. The rest of the code is more about 'exceptions' as a concept rather than a concrete Java class and eg. ThrowableSampleEvent sounds strange, at least to me.
jpbempel
approved these changes
Jun 9, 2020
Capture all exceptions by instrumenting `Throwable` constructors so they can be subsampled
jbachorik
force-pushed
the
jb/PROF-1622_sample_all_throwables
branch
from
dfb476b
to
c2b9e02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture all exceptions by instrumenting
Throwableconstructors so they can be subsampled.It became obvious that there are libraries/applications using even
Errortypes as a code flow control - generating 10s of thousands of error events. Therefore it makes sense to use the exception sampling facility to handle also errors and instrument thejava.lang.Throwableconstructor to get full coverage.