Rename Legacy Decorators to TagInterceptors #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are the downsides of moving these to the rules processing instead? They're conceptually the same except whether the work is done on the application threads or in the background. |
|
The reason these can't be moved to rules is because both service name and sampling priority directly effect other spans, so the evaluation cannot be delayed. |
tylerbenson
force-pushed
the
tyler/tag-interceptor
branch
from
25e3043
to
cc885ba
Compare
bantonsson
approved these changes
Jun 11, 2020
Now that most functionality is moved to the Rules, it doesn't need to do so much. Also more renaming
richardstartin
force-pushed
the
tyler/tag-interceptor
branch
from
cc885ba
to
c17d139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process, simplify AbstractTagInterceptor's responsibility. Now that most functionality is moved to the Rules, it doesn't need to do so much.
Reduce visibility on some of the newly renamed classes.