Allow OkHttp client to start when TLS is not configured #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomanderson
changed the title
richardstartin
approved these changes
Jun 12, 2020
tylerbenson
approved these changes
Jun 12, 2020
cimi
added a commit
that referenced
this pull request
Jun 15, 2020
Please see #1582 for the equivalent configuration in the trace agent. > When TLS was not configured in the JVM, the OkHttp client failed to > start with java.lang.AssertionError: No System TLS despite the fact > that we don't use TLS to communicate with the agent. > This change fixes that issue by limiting the OkHttp client to http > only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TLS was not configured in the JVM, the OkHttp client failed to start with
java.lang.AssertionError: No System TLSdespite the fact that we don't use TLS to communicate with the agent.This change fixes that issue by limiting the OkHttp client to
httponly.Tests are added for this case. I also added a check to the base CLI test to make sure traces are actually sent (similar to the OT smoketests)