Increase agent communication timeouts and add more logging #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
reviewed
Jun 15, 2020
utils/thread-utils/src/main/java/datadog/common/exec/DaemonThreadFactory.java
Outdated
Show resolved
Hide resolved
richardstartin
approved these changes
Jun 15, 2020
bantonsson
force-pushed
the
ban/better-reporting-logs
branch
2 times, most recently
from
ee74e78
to
353eba9
Compare
tylerbenson
approved these changes
Jun 15, 2020
bantonsson
force-pushed
the
ban/better-reporting-logs
branch
from
353eba9
to
75541ca
Compare
bantonsson
force-pushed
the
ban/better-reporting-logs
branch
from
75541ca
to
7f52f6b
Compare
This was referenced Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two parts:
1second to10seconds, since the communication happens on a separate thread and won't block application. It also tries to connect to the agent as soon as thewriteris started, again on the separate thread, to get the http client creation out of the way of normal sending.infolevel. The first success after failure logging is subject to the same quiet period as failure logging.Have tested and verified logging locally, since I can't figure out how to test that in unit tests in a nice way.
The timeout configuration option should be added to the docs. Where is that done?