allow context propagation for kafka tombstones #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
approved these changes
Aug 5, 2020
… impacted by headers
richardstartin
force-pushed
the
rgs/amend-kafka-tombstone
branch
from
db68bb1
to
510cc22
Compare
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 24, 2020
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 24, 2020
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 24, 2020
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 24, 2020
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 26, 2020
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 26, 2020
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 27, 2020
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 27, 2020
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 27, 2020
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 30, 2020
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Sep 1, 2020
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented this based on advice on a community issue that headers could prevent log compaction, without attempting to reproduce. I have since spoken to someone involved in the implementation of Kafka who reassured me that headers have no impact on log compaction whatsoever, so reverting the change, but keeping the tag in place because it seems useful.