Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add webflux filter multiple times #1803

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Conversation

bantonsson
Copy link
Contributor

The WebClient.Builder can be reused and we would add our filter multiple times, creating multiple spans.

@bantonsson bantonsson requested a review from a team as a code owner August 26, 2020 12:29
@bantonsson bantonsson self-assigned this Aug 26, 2020
Copy link
Member

@richardstartin richardstartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

@bantonsson bantonsson merged commit 6e74cee into master Aug 26, 2020
@bantonsson bantonsson deleted the ban/webflux-builder-reuse branch August 26, 2020 14:04
@github-actions github-actions bot added this to the 0.61.0 milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants