Make agent connect timeout less aggressive #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantonsson
commented
Aug 31, 2020
| try (Socket socket = new Socket()) { | ||
| socket.setSoTimeout(CONNECT_TIMEOUT_MS); | ||
| socket.connect(new InetSocketAddress(host, port)); | ||
| socket.connect(new InetSocketAddress(host, port), (int) timeoutMillis); |
There was a problem hiding this comment.
Actually use the timeout when trying to connect.
bantonsson
commented
Aug 31, 2020
| if (null == detectedVersion) { | ||
| log.debug("Tried all of {}, no connectivity to datadog agent", endpoints); | ||
| if (null == detectedVersion && log.isDebugEnabled()) { | ||
| log.debug("Tried all of {}, no connectivity to datadog agent", Arrays.asList(endpoints)); |
There was a problem hiding this comment.
This only logged the first element of the endpoints array.
tylerbenson
approved these changes
Aug 31, 2020
richardstartin
approved these changes
Aug 31, 2020
bantonsson
deleted the
ban/make-agent-connect-timeout-less-aggressive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported repeated failures to probe the
agentendpoints because of too low connect timeout.