Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove guava from profiling #1829

Merged
merged 2 commits into from
Sep 4, 2020
Merged

remove guava from profiling #1829

merged 2 commits into from
Sep 4, 2020

Conversation

richardstartin
Copy link
Member

@richardstartin richardstartin commented Sep 4, 2020 •
edited

Needs #1827 to be merged first.

Manually verified that guava classes are now under inst in the jar

jar -tf dd-java-agent/build/libs/dd-java-agent-0.61.0-SNAPSHOT.jar| grep 'com.google.common'
inst/com/google/common/
inst/com/google/common/escape/
inst/com/google/common/escape/Escapers$1.classdata
inst/com/google/common/escape/CharEscaperBuilder$CharArrayDecorator.classdata
...

@DataDog/profiling look at the second commit if reviewing this before rebasing after #1827 is merged.

@richardstartin richardstartin requested review from a team as code owners September 4, 2020 09:57
jbachorik
jbachorik approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@jbachorik jbachorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@richardstartin richardstartin merged commit 45961ce into master Sep 4, 2020
@richardstartin richardstartin deleted the rgs/remove-guava-from-profiling branch September 4, 2020 12:53
@github-actions github-actions bot added this to the 0.62.0 milestone Sep 4, 2020
@PerfectSlayer PerfectSlayer added comp: tooling Build & Tooling and removed remove guava labels Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

@bantonsson bantonsson bantonsson approved these changes

Assignees
No one assigned
Labels
comp: tooling Build & Tooling
Projects
None yet
Milestone
0.62.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@richardstartin @jbachorik @bantonsson @PerfectSlayer