Add the EnsureTrace prioritization strategy. #1841
Conversation
| @@ -537,8 +539,20 @@ private static Writer createWriter( | |||
| TimeUnit.SECONDS.toMillis(config.getAgentTimeout()), | |||
| Config.get().isTraceAgentV05Enabled()); | |||
|
|
|||
| final String prioritizationType = config.getPrioritizationType(); | |||
There was a problem hiding this comment.
If you rebase off master there is a configProvider.getEnum which would clean this up I think. The configuration parameter would be defined by the enum values themselves.
There was a problem hiding this comment.
As we commented offline, there is no a configProvider instance in CoreTracer yet. This will be refactored in the future.
...l-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/PrioritizationConstants.java
Show resolved
Hide resolved
drodriguezhdez
force-pushed
the
drodriguezhdez/blocking_prioritization_strategy
branch
from
6e86396
to
f74f520
Compare
| @@ -10,33 +10,87 @@ | |||
| import java.util.concurrent.TimeUnit; | |||
|
|
|||
| public enum Prioritization { | |||
| ENSURE_TRACE { | |||
| @Override | |||
| public PrioritizationStrategy create( | |||
There was a problem hiding this comment.
I think rather than Queue; this should either be...
create(Queue primary, Queue secondary)
OR
create(Queue<List> primary, Queue<List> secondary)
There was a problem hiding this comment.
There was a discussion about this at the time. Accepting Object allows the flush messages and avoids allocating wrappers, but it has downsides, so we don't want this ever escaping the package.
drodriguezhdez
deleted the
drodriguezhdez/blocking_prioritization_strategy
branch
Added a new
PrioritizationStrategytries to offer the trace to the primary queue until thequeue.offer(...)method returns true. This type can be configured viaConfig.This new type is needed to avoid losing spans in CI/Tests traces. It should not be used in applications in production mode.