Port otel/1090 #1852
Merged
Port otel/1090 #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinsba
force-pushed
the
brian.devinssuresh/otel-1090
branch
from
1b52061
to
d1df54f
Compare
devinsba
commented
Sep 9, 2020
| @@ -1,77 +0,0 @@ | |||
| package datadog.trace.instrumentation.java.concurrent; | |||
| @@ -12,9 +11,6 @@ | |||
| @Slf4j | |||
| public class ExecutorInstrumentationUtils { | |||
|
|
|||
| private static final WeakMap<Executor, Boolean> EXECUTORS_DISABLED_FOR_WRAPPED_TASKS = | |||
There was a problem hiding this comment.
Aww I hate seeing these disappear :(
richardstartin
approved these changes
Sep 9, 2020
tylerbenson
approved these changes
Sep 9, 2020
devinsba
force-pushed
the
brian.devinssuresh/otel-1090
branch
from
fb76613
to
281abc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports open-telemetry/opentelemetry-java-instrumentation#1090 from @trask which since I also believe this is not needed.
TODO add some tests with java 8 and lambdas to ensure this isn't breaking things subtly and add some tests around executors that are on our classpath that have their own queue implementations