Enable health metrics by default #1871
Merged
+136
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
approved these changes
Sep 15, 2020
richardstartin
approved these changes
Sep 16, 2020
|
I suggest updating the pr name/description with more useful verbiage for the release notes. |
|
This change breaks some CustomLogManager tests. Investigating further |
lpriima
approved these changes
Sep 23, 2020
|
@randomanderson I suspect this is because of DogStatsD's usage of |
randomanderson
force-pushed
the
landerson/health-metrics-by-default
branch
from
a4587de
to
8fa3988
Compare
|
I suspect we may need to plug the executors used by JMXFetch/DogStatsD, since some of these are still failing with the same cause. |
|
This will likely be in a better state after #1958 is merged. |
randomanderson
force-pushed
the
landerson/health-metrics-by-default
branch
from
8fa3988
to
ea9c5fb
Compare
randomanderson
force-pushed
the
landerson/health-metrics-by-default
branch
from
4cf8466
to
39cb0c7
Compare
tylerbenson
reviewed
Oct 19, 2020
| def tracer = CoreTracer.builder().build() | ||
| // FIXME this line should be unnecessary but a system property is leaking from somewhere | ||
| // Remove when config overrides is fixed | ||
| System.setProperty(PREFIX + HEALTH_METRICS_ENABLED, "true") |
There was a problem hiding this comment.
perhaps this should clear the property instead of setting to true?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.