-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setters to span.metrics from MutableSpan #1985
Conversation
@@ -201,6 +201,21 @@ public MutableSpan setTag(final String tag, final Number value) { | |||
return delegate.setTag(tag, value); | |||
} | |||
|
|||
@Override | |||
public MutableSpan setMetric(final String metric, final int value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make that CharSequence
- you still get to use String
but we could use UTF8BytesString
internally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR adds an accessor to the
span.metrics
through theMutableSpan
interface.