Ensure ForkJoinTask is field-injected, add smoke test for field injection #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
force-pushed
the
rgs/field-injection-smoke-tests
branch
2 times, most recently
from
245a195
to
fe7f908
Compare
bantonsson
approved these changes
Oct 15, 2020
mcculls
approved these changes
Oct 15, 2020
devinsba
approved these changes
Oct 15, 2020
…Task and ForkJoinTask
richardstartin
force-pushed
the
rgs/field-injection-smoke-tests
branch
from
fe7f908
to
0060c55
Compare
richardstartin
commented
Oct 15, 2020
| @@ -49,7 +49,7 @@ public boolean matches(TypeDescription target) { | |||
| } | |||
|
|
|||
| @Override | |||
| public Map<String, String> contextStore() { | |||
| public Map<String, String> contextStoreForAll() { | |||
There was a problem hiding this comment.
this wasn't necessary but can't hurt
richardstartin
changed the title
PerfectSlayer
added
tag: performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.