Fail-fast manual tracer creation in presence of java agent #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
approved these changes
Oct 15, 2020
tylerbenson
approved these changes
Oct 15, 2020
| public class IncorrectSetupWithAgentApplication { | ||
| public static void main(final String[] args) { | ||
| try { | ||
| DDTracer.builder().build(); |
There was a problem hiding this comment.
Do you want to throw an assertion error after this in case it doesn't fail as expected?
...ntracing/src/main/java/datadog/smoketest/opentracing/IncorrectSetupWithAgentApplication.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tyler Benson <tyler.benson@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, we would allow the creation of
DDTracereven when the java agent was installed. The failure to register was noted in the logs and the application continued normally.Recently, creating
DDTracerwhen the agent was installed causesjava.lang.NoSuchMethodErrorbecause of class renaming.In both cases, the newly created
DDTracercan't be used. This pull request changes the behavior to fail fast by throwing an exception immediately.