Add missing equals and hashCode method into datadog.trace.instrumentation.opentracing32.OTSpan #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion.opentracing32.OTSpan It's not possible to check equality of opentracing32.OTSpan intances because it doesn't implement the equals and hashCode methods for the internal agent span. Also the opentracing32.OTSpan class is not part of public API and the getDelegate method is not assessible via the Span or MutableSpan inteface. At the same time datadog.opentracing.OTSpan has proper implementations of the equals and hashCode methods.
devinsba
approved these changes
Oct 15, 2020
richardstartin
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to check equality of opentracing32.OTSpan intances because it doesn't implement the equals and hashCode methods for the internal agent span. Also the opentracing32.OTSpan class is not part of public API and the getDelegate method is not assessible via the Span or MutableSpan inteface.
At the same time datadog.opentracing.OTSpan has proper implementations of the equals and hashCode methods.