Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude internal agent threads from exception profiling #1998

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Exclude internal agent threads from exception profiling #1998

merged 2 commits into from
Oct 16, 2020

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Oct 16, 2020 •
edited

Profiling of agent threads can be re-enabled by system property:

-Ddd.profiling.exclude.agent-threads=false

or by environment variable:

DD_PROFILING_EXCLUDE_AGENT_THREADS=false

@mcculls mcculls requested a review from a team as a code owner October 16, 2020 15:28
richardstartin
richardstartin approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@richardstartin richardstartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are pros and cons here. This will save some cycles, and makes startup much more predictable. On the other hand it would be nice to be able to enable it for diagnostic purposes.

@mcculls mcculls merged commit 45944ec into master Oct 16, 2020
@mcculls mcculls deleted the mcculls/avoidProfilingExceptionsFromAgentThreads branch October 16, 2020 17:33
@github-actions github-actions bot added this to the 0.66.0 milestone Oct 16, 2020
@mcculls mcculls mentioned this pull request Oct 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbenson tylerbenson tylerbenson left review comments

@bantonsson bantonsson bantonsson approved these changes

@richardstartin richardstartin richardstartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.66.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcculls @tylerbenson @bantonsson @richardstartin