Reduce field injection footprint #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
force-pushed
the
rgs/reduce-field-injection-footprint
branch
from
367eabf
to
e37eb02
Compare
mcculls
reviewed
Oct 19, 2020
...ava/datadog/trace/instrumentation/scala/concurrent/PromiseTransformationInstrumentation.java
Outdated
Show resolved
Hide resolved
richardstartin
force-pushed
the
rgs/reduce-field-injection-footprint
branch
from
e37eb02
to
221515c
Compare
bantonsson
approved these changes
Oct 19, 2020
| @@ -78,11 +79,11 @@ public static boolean exclude(ExcludeType type, String className) { | |||
| * | |||
| * @param excludeTypes the types to exclude | |||
| */ | |||
| public static void add(Map<ExcludeType, Set<String>> excludeTypes) { | |||
| public static void add(Map<ExcludeType, ? extends Collection<String>> excludeTypes) { | |||
…ion to reduce footprint
richardstartin
force-pushed
the
rgs/reduce-field-injection-footprint
branch
from
221515c
to
7da0d0f
Compare
mcculls
approved these changes
Oct 19, 2020
richardstartin
commented
Oct 19, 2020
...t/agent-tooling/src/main/java/datadog/trace/agent/tooling/context/FieldInjectionVisitor.java
Outdated
Show resolved
Hide resolved
richardstartin
force-pushed
the
rgs/reduce-field-injection-footprint
branch
from
7da0d0f
to
12bf9f9
Compare
PerfectSlayer
added
tag: performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the overhead of injected fields by manually excludes as many instrumentable
RunnableFutures as possible to preventRunnableInstrumentationfrom injecting these types. These changes reduces field injection footprint from2 * depth * widthtodepth * widthin most cases.