Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture scope if necessary before Scala 2.13 Transformation enters an ExecutionContext #2015

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Capture scope if necessary before Scala 2.13 Transformation enters an ExecutionContext #2015

merged 2 commits into from
Oct 21, 2020

Conversation

richardstartin
Copy link
Member

No description provided.

@richardstartin richardstartin requested a review from a team as a code owner October 20, 2020 18:28
bantonsson
bantonsson reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing some rationale as to why this change is proposed. What is the use case that it's trying to fix?

...ava/datadog/trace/instrumentation/scala/concurrent/PromiseTransformationInstrumentation.java Outdated Show resolved Hide resolved
@richardstartin
Copy link
Member Author

@bantonsson the idea is when a Transformation is mapped, creating a new Transformation, any state from the first Transformation is passed on to the next one. Otherwise there may be no scope active when the mapped Transformation is constructed, so no span will be active when it's later run. Something like the ConcurrentState might be a better idea because we don't know that the first Transformation will never be run.

@richardstartin richardstartin force-pushed the rgs/transfer-state-in-map branch 2 times, most recently from 83571f3 to 6ad52a5 Compare October 21, 2020 07:46
@richardstartin richardstartin changed the title transfer state when scala 2.13 transformation is mapped Capture scope if necessary before Scala 2.13 Transformation enters an ExecutionContext Oct 21, 2020
@richardstartin richardstartin merged commit acd520f into master Oct 21, 2020
@richardstartin richardstartin deleted the rgs/transfer-state-in-map branch October 21, 2020 15:31
@github-actions github-actions bot added this to the 0.66.0 milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbenson tylerbenson tylerbenson approved these changes

@bantonsson bantonsson bantonsson approved these changes

@randomanderson randomanderson Awaiting requested review from randomanderson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.66.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@richardstartin @tylerbenson @bantonsson