Add self signed ssl to test server and test netty client #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
force-pushed
the
tyler/netty-client-https-testing
branch
6 times, most recently
from
401322a
to
ec2130c
Compare
Update netty client instrumentation to accurately capture if https.
tylerbenson
force-pushed
the
tyler/netty-client-https-testing
branch
from
ec2130c
to
0743bdc
Compare
| @@ -39,13 +40,15 @@ public void write(final ChannelHandlerContext ctx, final Object msg, final Chann | |||
| final HttpRequest request = (HttpRequest) msg; | |||
|
|
|||
| ctx.channel().attr(AttributeKeys.CLIENT_PARENT_ATTRIBUTE_KEY).set(activeSpan()); | |||
| boolean isSecure = ctx.pipeline().get("ssl") != null; | |||
| NettyHttpClientDecorator decorate = isSecure ? DECORATE_SECURE : DECORATE; | |||
There was a problem hiding this comment.
Can we make this a noun not a verb? I've always found this convention a bit strange to read
There was a problem hiding this comment.
I'd prefer to keep it consistent for now. If we want to change it, that should be done everywhere.
There was a problem hiding this comment.
I'm not sure, changing the names in one go is a cross cutting (i.e. disruptive) change. This is a new local variable name and doesn't need to be consistent with anything.
There was a problem hiding this comment.
If you let me know what you'd prefer, I'll' make a PR that changes it everywhere.
dd-java-agent/testing/src/main/resources/datadog/trace/agent/test/server/http/README.md
Show resolved
Hide resolved
bantonsson
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update netty client instrumentation to accurately capture if https.